Python logging equivalent

AAltairSama2

Hey folks, I am porting our existing selenium based scrapers to crawlee and one thing I am used to is how verbose we can set the logging in python, is there an equivalent in crawlee?

for e.g.

Here's my logging format in python:
logging.Formatter("%(asctime)s %(name)s:%(levelname)s [%(funcName)s:%(lineno)d] %(message)s")

and we also have support for rotating logs in python.

i went through the docs and while I found how to add timestamp in the logs, there's no mention of func names or even code line numbers, The only thing I found is that we can extend default loggers in crawlee so can someone post a minimal example of how to extend these loggers to add in func names etc?

or is there support for third party logging libraries like winston that I can use for this? I am using PlayWright if that matters.

16 comments

PPepa J

Hi
There is an example of implementation of setting custom logger in Typescript based on LoggerText class. Check the LoggerText for other method that you might want to override like warning(...), error(...) :

Plain Text

import { log, LoggerText, LogLevel } from 'crawlee';

class MyLogger extends LoggerText {
    override log(level: LogLevel, message: string, data?: any, exception?: any) {
        console.log(`My own log `, level, message, data, exception);
    }

    // ...
}

log.setOptions({
    logger: new MyLogger(log.getOptions()),
});

Hope this helps.

AAltairSama2

hey, thanks, how would I go about passing in extra arguments for my logs? like say line no, module name, func name etc. will it be something like this?

Plain Text

class MyLogger extends LoggerText {
    override log(level: LogLevel, message: string, data?: any, exception?: any, extraArgs: any) {
        console.log(`My own log `, level, message, data, exception, extraArgs);
    }

    // ...
}

//calling it like this?
logger.info(message, data, extraArgs)

AAltairSama2

And can you link the tyepscript implementation you mentioned? I found the log implementation here https://github.com/apify/apify-shared-js/blob/master/packages/log/src/logger_text.ts and have been going through this package to figure out my own, is this the correct place because I couldn't find it in the crawlee repo or in the docs.

PPepa J

So there are "system" logs coming from Crawlee,, these will always use currently set Logger, which will always use the same method signatures and you cannot do much about it.
If you want to provide custom parameters to log, that is what the data parameter is for, but you need to always pass them by yourself.

Plain Text

log.info(`MY log message`, {
    myData1: 'data1',
    myData2: 'data2'
})

I am afraid that there is no way for JS/TypeScript to provide information about line number, or name of the parent method from which they were called etc.

I originally thought, that you are just interested in a way the logs are formatted

AAltairSama2

gotcha, thanks for the info! this is really helpful, I'll hack together a solution that works for myself thanks

AAltairSama2

and I'm assuming I'll have to implement rotating logs etc on my own right?

AApifyBot

just advanced to level 1! Thanks for your contributions! 🎉

AAltairSama2

using the example above?

AAltairSama2

do we have an option where I can write the logs to a buffer or anything which in turn will update the .log file?

AAltairSama2

or is it like open the buffer in code

AAltairSama2

and then pass it in using data?

PPepa J

If you want to solve this on application level then yes, I am afraid you need to solve such cases by yourself.

What I put as example is just a middleware for the logs, so I believe you might use some 3rd party solution for logs in it, such as Winston ( https://stackoverflow.com/questions/18055971/log-rotation-in-node-js ) which may cover some of the cases like logging into file based etc.

AAltairSama2

ah got it, so in the example you linked, we can omit the console.log which does the actual logging and instead pass in these parameters to Winston or something which will do this for us?

AAltairSama2

this'll really help a lot

PPepa J

Yes, something like that.

AAltairSama2

thanks for the help!

Add a reply

Apify and Crawlee Official Forum

Python logging equivalent